Vantage Theme Premium Still missing translation “Leave a comment”

Hi Musher

Thanks for posting.

Can you please, send us a link to a page showing the string that isn’t translating. I think I know what’s happened there but would be best to confirm by inspecting the string on your site.

I’m not sure why Poedit won’t translate the string you’ve raised. Loco Translate seems ok with it. You can see the string here: https://github.com/siteorigin/vantage/blob/cc7d5104277ce76b01de6e61828f5dd1ebec001d/inc/class-tgm-plugin-activation.php#L388. All seems normal with that translation function.

Is this the translation you’re referring to?

#: inc/class-tgm-plugin-activation.php:388
msgid "The following plugin was activated successfully:"
msgstr ""

Thanks for the detailed feedback.

No Comments

If you have a moment, you can see the No Comments function here, it’s called: get_comments_number_text()

https://github.com/siteorigin/vantage/blob/develop/inc/template-tags.php#L176

What this means is that we aren’t passing any arguments through this function anymore. As a result, all of the strings that this function outputs should be automatically translated by WordPress. For example, if I change my WP install to Italian, the No Comments string translates:

WP set to English:

WP set to Italian:

No comments and any strings outputted by that function won’t appear in the vantage.pot file, they’re default WordPress strings that will change according to whatever the Settings > General language is set to.

Posted on

Posted on is still in the vantage.pot file. If you do an in page search here: https://themes.svn.wordpress.org/vantage/1.5.3/languages/vantage.pot you’ll find it.

I can see it in your link too: https://u.teknik.io/I9LIQ.pot

Other

Apologies for the core error, I’ll log that now for the team to look into.

What is the core language of your WordPress install set to?

If you’d like to try a little custom work:

1. Plugins > Add New, search for, install and activate Code Snippets plugin.
2. Snippets > Add New, name : Vantage Custom Posted On, insert the following as the function:

http://pastebin.com/YKr1qbf1

3. Select the option to only run on site front end, Save changes and activate.

4. Edit my function, locate lines 24 and 25 where I say, one, two, three:

one = Text for no comments.
two = Text for one comment.
three = Text for more than one comment.

You can replace those words as required. You can also directly edit the Posted on string on line 30.

Let me know if you feel like trying this.

Super. I can’t login to assist since it’s local but can offer advice. Let me know how it goes :)

Only works for me if I turn off Loco Translate so there might be a conflicting translation file.

Would you be prepared to wait until your site is online? If so, let me know as soon as it’s live and I’ll login and take a look. At this point, that’ll be the quickest / easiest way we can resolve. You can then also move on with your site dev and we’ll come back to this as soon as the site is live.

Thanks for your feedback. I’m glad to hear you were able to make partial progress. Please, could we inspect this problem once you site is live?

Sorry, not quite with you there.

My suggestion is rather than work the problem remotely, launch your site, at which time you can drop us a message here, it’ll rise straight to the top of my list, I’ll pick it up promptly and we’ll inspect the issue live, hopefully, resolving it quickly. I’m suggesting this course of action because I can’t recreate the final issue locally. Usually, at this stage we’d login and check the issue live.

If you’re using Vantage Premium or SiteOrigin Premium, you’ll welcome to contact us via email, alternatively, for Vantage Free, we offer forum support. My name is above each reply.

Awesome :) Thanks. Instructions to follow.