Hey, guys,
one of the last updates resulted in a very unfavorable change for us. Previously, the styles entered in the PageBuilder for a specific line affected a div with the class panel-widget-style. Now, however, parts of the adjustments affect the element above it with the class so-panel. This is a very good idea because it allows you to hide an entire line without leaving any pointless markup. But firstly, this means massive interventions on old websites, and secondly, as mentioned above, it only affects parts of the CSS adjustments. Some are on so-panel, some on panel-widget-style. This is very unfavourable and should, in our opinion, be reversed as soon as possible.
We are looking forward to a quick response.
Thank you and greetings,
Christian
Hi Christian
Thanks for letting us know.
Here is what was done:
https://github.com/siteorigin/siteorigin-panels/commit/82fd1eb3a2a7cc3883868b9628b91d9dbf8ab220
Bottom margin custom styles are now applied to the main wrapper where Page Builder adds its own bottom margin. This allows users to override this setting. Resolves GH-437
Can you perhaps send us a URL with a problem that’s resulted from this fix and point out on the page where the problem is so we can better understand the issue that’s arisen?
Ah, i see, you meant this purposefully. Sorry, this change affects almost all of our websites and requires us to change our settings there. Is there any chance you could make this voluntarily?
You can see our use here, focus on the mobile apps section: https://www.invoiz.de/angebote-und-rechnungen-in-sekunden-erstellen-und-direkt-versenden
Thanks for your feedback. We’ll find a way to resolve one way or another.
If you’re up for a little more feedback. So is this the rule that’s being impacted after the update?
#pg-13716-10>.panel-row-style { background-color: #1c7bf1; background-image: url(https://www.invoiz.de/wp-content/uploads/2018/04/blaubg.jpg); background-position: center center; background-size: cover; padding: 40px 0px 40px 0px; }I’m trying to map out the exact impact in this case.
Nope, it’s the styles of the mobile mockups themselfes:
We need to move the mockups up and down based on the responsive view. This can only be done with the textarea-field in the attributes, because your margin-fields don’t break down into responsive loops.
Thanks for the detailed feedback. Greg will take a look ASAP on Monday. We might need to revert this change. Appreciate the help. Will update you ASAP as to the plan.
Hey, any updates on this? Best, Christian
Hey Christian, sorry for the delay. We’re going to roll this change back. Our thinking was that all or most declarations should apply to the child div, for example, color: red; won’t matter that it’s applied to the parent and not the child. But, margin wouldn’t do that so we added a workaround for that. But if the fix is causing significant legacy issues then it isn’t worth it. I’ll find out when we can release this update and let you know ASAP.
That’s very good news, thanks a lot!
For sure. Sorry again for the delays. Will update you as soon as I’ve spoken to the team about a release date. Sure it’ll be quite soon.
Just wanted to check if there’s a schedule yet? Thanks!
Hi Christian. Thanks for checking. Sorry, the update hasn’t gone out yet. I don’t have an exact timeline, if you can continue to run the last version for the moment, that would be best. Thanks for hanging in there with us. As soon as there are a few more items to add to the update we’ll send it out.
Thanks for the update. We should have the update out shortly.