This thread is over two years old and may be outdated. Please create a new thread if you need help, or email us if you have an active Premium license.

Please fix this code if it possible without problems

Open 3 replies developerpluginplugin-page-builder
Vladimir Plotvinov
8 years ago · Last reply by Alex S 8 years ago

I found this code:

siteorigin-panels.php:211

ob_start();
if( !empty($template_file) && file_exists($template_file) ) {
    extract( $template_vars );
    @ include $template_file;
}
$template_html = ob_get_clean();

Use “@” is not good practice as for me. I spent 7 hours only on debugging and found this…

This is our free support forum. Replies can take several days.

Need fast email support? Get SiteOrigin Premium

Replies

3
  1. Alex S Staff 8 years, 2 months ago

    Hi Владимир,

    I’ve forwarded your feedback to the development team.
    This likely won’t be completely removed, but it’ll likely be put behind a wp_debug check.

    To clarify, what caused your specific error (that was hidden)? I ask as I’ll include that as a use case.

  2. Vladimir Plotvinov 8 years, 2 months ago

    Hi Alex! Thank you for forwarded!

    After save page in wp-admin, I get clear-html from widgets only (default.php) without admin panel.
    I don’t understand why page is not save right. When I found “@” with xdebug and removed it.
    I learned that I have a problem with function name duplicated in different default.php files.

  3. Alex S Staff 8 years, 2 months ago

    Hi Vladimir,

    Thank you for the follow up reply. I’ve included a copy your post with the forwarded information.

Replies on this thread are closed.

Please create a new thread if you have a question, or purchase a SiteOrigin Premium license if you need one-on-one email support.

Have a different question or issue?

Start New Thread