Home>Support>menubar search

menubar search

By Nearly Legal, 9 years ago. Last reply by Andrew Misplon, 9 years ago.

Updated to vantage premium 2.4.2 – the search in the masthead menubar now has a persistent drop down search box on first loading (see http://nearlylegal.co.uk/blog/ ). Is there a way to toggle this so that it appears on click on search icon rather than by default?

Also, on first updating to 2.4, the background header image was removed, despite the theme being a child theme. The background image had to be re-coded into the child theme style.css and using custom.css didn’t seem to over-ride it. I solved the problem, but it was an issue with the update.

URL: http://nearlylegal.co.uk/blog/

This is our free support forum. Replies can take several days. If you need fast email support, please purchase a SiteOrigin Premium license.

  1. 9 years, 5 months ago Andrew Misplon
    Hi, I Work Here

    Hi Nearly Legal

    Sorry to hear about the hassles. Please can you check your child theme. Is there a searchform.php file in there? If so, please could you check searchform.php in the parent theme as there were updates made to that file.

    Thanks

  2. 9 years, 5 months ago Nearly Legal

    Hi – there is a searchform.php in the child theme. What am I checking for in the parent theme searchform.php ? And should it be taking precedence over the child theme version, which should be unchanged?

  3. 9 years, 5 months ago Andrew Misplon
    Hi, I Work Here

    Sorry for not explaining further. I didn’t look into exactly what the guys changed there. Sure, your searchform.php will remained un-changed in the child theme. If however an adjustment was made to the JavaScript or CSS that the form uses you’ll run into a problem. My idea was to check the new searchform.php and merge it with your current searchform.php. So basically move whatever changes you made the file, over to the new version.

    Here is the new version:

    <?php
/**
 * The template for displaying search forms in vantage
 *
 * @package vantage
 * @since vantage 1.0
 * @license GPL 2.0
 */
?>

<form method="get" class="searchform" action="<?php echo esc_url( home_url( '/' ) ); ?>" role="search">
	<input type="text" class="field" name="s" value="<?php echo esc_attr( get_search_query() ); ?>" placeholder="<?php esc_attr_e( 'Search', 'vantage' ); ?>"/>
</form>

    And here is the old version:

    <?php
/**
 * The template for displaying search forms in vantage
 *
 * @package vantage
 * @since vantage 1.0
 * @license GPL 2.0
 */
?>

<form method="get" id="searchform" action="<?php echo esc_url( home_url( '/' ) ); ?>" role="search">
	<label for="s" class="assistive-text"><?php _e( 'Search', 'vantage' ); ?></label>
	<input type="text" class="field" name="s" value="<?php echo esc_attr( get_search_query() ); ?>" id="s" placeholder="<?php esc_attr_e( 'Search', 'vantage' ); ?>" />
	<input type="submit" class="submit" name="submit" id="searchsubmit" value="<?php esc_attr_e( 'Search', 'vantage' ); ?>" />
</form>

    I’ll run a diff inspection in a moment and try help out a bit more :)

  4. 9 years, 5 months ago Andrew Misplon
    Hi, I Work Here

    Perhaps you could let us know what you changed in searchform.php or just paste your version here. We can then help merge those changes into the new version. Should be the fastest way to proceed.

  5. 9 years, 5 months ago Nearly Legal

    Thanks for this so far. I hadn’t changed anything. The behaviour and appearance of the in menu search changed with the 2.4 or 2.4.2 update.

  6. 9 years, 5 months ago Nearly Legal

    This is searchform.php from the child theme

    <form method="get" id="searchform" action="” role=”search”>

    <input type="text" class="field" name="s" value="” id=”s” placeholder=”” />
    <input type="submit" class="submit" name="submit" id="searchsubmit" value="” />

  7. 9 years, 5 months ago Nearly Legal

    Sorry missed the code tags

    <?php
/**
 * The template for displaying search forms in vantage
 *
 * @package vantage
 * @since vantage 1.0
 * @license GPL 2.0
 */
?>

<form method="get" id="searchform" action="<?php echo esc_url( home_url( '/' ) ); ?>" role="search">
	<label for="s" class="assistive-text"><?php _e( 'Search', 'vantage' ); ?></label>
	<input type="text" class="field" name="s" value="<?php echo esc_attr( get_search_query() ); ?>" id="s" placeholder="<?php esc_attr_e( 'Search', 'vantage' ); ?>" />
	<input type="submit" class="submit" name="submit" id="searchsubmit" value="<?php esc_attr_e( 'Search', 'vantage' ); ?>" />
</form>
  8. 9 years, 5 months ago Andrew Misplon
    Hi, I Work Here

    Thanks for confirming. If you haven’t made any changes to searchform.php you should be able to remove it from your child theme. Can you perhaps give that a try?

  9. 9 years, 5 months ago Nearly Legal

    Perfect – that worked. Thank you!

  10. 9 years, 5 months ago Andrew Misplon
    Hi, I Work Here

    Super, glad that helped. All the best :)

Replies on this thread are closed. Please create a new thread if you have a question, or purchase a SiteOrigin Premium license if you need one-on-one email support.

Get The Most Out of SiteOrigin with SiteOrigin Premium

Find Out More