Notice: This thread is over two years old; the information may be outdated. Please consider creating a new thread if you require free support. If you have an active SiteOrigin Premium license, you can email our premium support desk at [email protected].
Hi Greg,
I would like to request that you add 2 more action hooks to Vantage
comments_before
comments_after
I have built a plugin that adds support to Vantage for all the action hooks, and these 2 extra hooks would simply close off all the locations that are generally used on themes that have gone the extra mile to actually add these hooks.
Much appreciated.
– Ciaran
Hi Ciaran
Thanks for your feedback, I’ve passed it onto Greg. It sounds like the theme review guidelines are still unsure about whether comments_before and comments_after are allowed without prefixing them with the theme namespace.
(If you need these for your own usage you could add them via a child theme)
Thanks for passing on to Greg, I cannot see why it wouldn’t pass the guidelines as these are structural areas that should be fine to add. These are only suggestions as I have seen numerous themes and frameworks include these locations.
Basically I am only testing the theme against the plugin that is near completion that will turn Vantage into a fairly incredible framework in an instant. Stay tuned on that development. But if these 2 hooks will make it to core of Vantage, I will add them to the plugin array in support of them being added.
Does the other Site Origin themes use the same action hooks?
As far as adding them to a child theme, yes I am quite aware of that, have been adding action hooks from THA to child themes a bit now as I get huge use out of them in development of sites. Again, stay tuned on something big coming in a couple of weeks once all testing is complete.
Ahh ok I’m with you now. I don’t know the particulars, perhaps the theme review debate was just around whether the hooks needed to be prefixed or not. Thanks for considering Vantage in your testing. I’ll pass this further information onto Greg.
I think it’s only one of our older themes, Pitch, that includes comments_before, but prefixed with the theme name:
function pitch_comments_before_form(){ print '<div class="separator"></div>';}add_action('comment_form_before', 'pitch_comments_before_form');Awesome, thanks Greg.
As for the other themes, do they use the same action hooks? Possibly you could ask Greg, and if so I will add these also.
Sorry for missing that question. Doing a search of my local SiteOrigin theme folder only brings up Pitch.
ok, and what about all the action hooks, are all the themes using the same action hook list? Or are they all individually prefixed? If they are all individually prefixed, then I can select a couple of the themes to include in the support on the plugin. If this is the case, you are best to advise which you would want added to the plugin.
As it stands right now it’s just Pitch that has a prefixed comments_before hook. The hooks, prefixed, or not, aren’t present in any of our other themes as far I can see.
Ahh what a pity, so Vantage is pretty much the only theme that make use of any action hooks?
Here is attached the Codecanyon snippet I am getting ready for the assets.
http://i.imgur.com/wCH3aQn.jpg
Are there any other hooks besides comments_before and comments_after that you’re checking for? I just briefly searched for those two.
Ahh, was only a suggestion to add them the vantage theme. But basically I can add every action hook available per theme to the plugin array. If all action hooks are the same across all themes then it makes it simple for me since I have already added the 14 available in vantage.
If Greg or yourself add a full set of action hooks to the other themes then I will add this to the list of supported themes in the codecanyon description assets.
Hope that makes sense.
Am driving home at the moment and pulled over to reply. Am happy to call over Skype if you like. Might be easier?
cmwwebfx – skype
Thanks for the follow-up explanation. I’ll need to swing this over to Greg from here.