Bugfix for Influence theme regarding Site Description overlapping the slider
Hello,
I encountered a problem and fixed it. I hope you can reproduce it and put the fix into the public.
Reproduction:
* WordPress 4.0
* Influence 1.06
* Demo Homepage with the default Demo Slider
* Settings -> Apperance -> Theme Settings -> Logo -> Site Description = Enabled
* Settings -> Apperance -> Theme Settings -> Home Page -> Menu Overlaps Slider = Disabled
Effect:
* Slider’s position is too high.
* Header and Slider overlap.
* Slider shines through the header.
Cause:
* Sentinel does not check for “Logo -> Site Description”
Fix:
* file: inc/template-tags.php
* function influence_site_header_sentinel()
* fix could be better integrated into the existing if, but this is proof-of-concept
Without fix:
function influence_site_header_sentinel(){
?>
<div class="site-header has-shadow site-header-sentinel">
<div class="container">
<div class="hgroup">
<h1 class="site-title">
<?php influence_display_logo(); ?>
</h1>
<?php if(siteorigin_setting('general_site_description')) : ?>
<h2 class="site-description"><?php bloginfo( 'description' ); ?></h2>
<?php endif ?>
</div>
With fix:
function influence_site_header_sentinel(){
?>
<div class="site-header has-shadow site-header-sentinel">
<div class="container">
<div class="hgroup">
<h1 class="site-title">
<?php influence_display_logo(); ?>
</h1>
<?php if(siteorigin_setting('general_site_description')) : ?>
<h2 class="site-description"><?php bloginfo( 'description' ); ?></h2>
<?php endif ?>
<!-- fix: -->
<?php if(siteorigin_setting('logo_site_description')) : ?>
<h2 class="site-description"><?php bloginfo( 'description' ); ?></h2>
<?php endif ?>
</div>
Greetings
This is our free support forum. Replies can take several days.
Need fast email support? Get SiteOrigin Premium
Replies
1Hi Dinh Bao Dang
Thanks very much for your contribution. I’ll log this as a bug report for Greg to attend to as soon as possible.
Thanks again for getting involved.
All the best.
Replies on this thread are closed.
Please create a new thread if you have a question, or purchase a SiteOrigin Premium license if you need one-on-one email support.